Use property_exists instead of isset

result and id can be null, in which case isset() returns false event though they are present in the JSON

Author: felixfbecker

lib/Message.php

@@ -35,6 +35,8 @@ public static function parse(string $msg): Message
             $obj = new SuccessResponse($decoded->id, $decoded->result);
         } else if (ErrorResponse::isErrorResponse($decoded)) {
             $obj = new ErrorResponse($decoded->id, new Error($decoded->error->message, $decoded->error->code, $decoded->error->data ?? null));
+        } else {
+            throw new Error('Invalid message', ErrorCode::INVALID_REQUEST);
         }
         return $obj;
     }

lib/Notification.php

@@ -41,7 +41,7 @@ class Notification extends Message
      */
     public static function isNotification($msg): bool
     {
-        return is_object($msg) && !isset($msg->id) && isset($msg->method);
+        return is_object($msg) && !property_exists($msg, 'id') && isset($msg->method);
     }
 
     /**

lib/Request.php

@@ -46,7 +46,7 @@ class Request extends Message
      */
     public static function isRequest($msg): bool
     {
-        return is_object($msg) && isset($msg->id) && isset($msg->method);
+        return is_object($msg) && property_exists($msg, 'id') && isset($msg->method);
     }
 
     /**

lib/Response.php

@@ -25,7 +25,7 @@ abstract class Response extends Message
      */
     public static function isResponse($msg): bool
     {
-        return is_object($msg) && isset($msg->id) && (isset($msg->result) || isset($msg->error));
+        return is_object($msg) && property_exists($msg, 'id') && (property_exists($msg, 'result') || isset($msg->error));
     }
 
     /**

lib/SuccessResponse.php

@@ -25,7 +25,7 @@ class SuccessResponse extends Response
      */
     public static function isSuccessResponse($msg): bool
     {
-        return is_object($msg) && isset($msg->id) && isset($msg->result);
+        return is_object($msg) && property_exists($msg, 'id') && property_exists($msg, 'result');
     }
 
     /**