Skip to content

Conversation

@gfischer7
Copy link
Contributor

@gfischer7 gfischer7 commented Dec 8, 2025

Fixed two subject-verb agreement errors:

  • Line 69: pubkeys existspubkeys exist
  • Line 140: all of them together doesall of them together do

@gfischer7 gfischer7 requested a review from eth-bot as a code owner December 8, 2025 15:00
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Dec 8, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 8, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Dec 8, 2025
@eth-bot eth-bot changed the title Update EIP-8071: Fix balance type inconsistency in consolidation check Update EIP-8071: Fix balance type inconsistency in consolidation check Dec 8, 2025
@mkalinin
Copy link
Contributor

mkalinin commented Dec 9, 2025

When consolidations are processed, the full actual balance (not just effective balance) is transferred.

Consolidation balance is capped by the source.effective_balance, which is the reason to use source.effective_balance for this computation. The limitation is here:

https://github.com/ethereum/consensus-specs/blob/daef46377cb5926af7d729fd533cbadc73fda117/specs/electra/beacon-chain.md?plain=1#L1037-L1039

@gfischer7 gfischer7 changed the title Update EIP-8071: Fix balance type inconsistency in consolidation check Update EIP-8071: Fix grammar errors Dec 9, 2025
@gfischer7
Copy link
Contributor Author

When consolidations are processed, the full actual balance (not just effective balance) is transferred.

Consolidation balance is capped by the source.effective_balance, which is the reason to use source.effective_balance for this computation. The limitation is here:

https://github.com/ethereum/consensus-specs/blob/daef46377cb5926af7d729fd533cbadc73fda117/specs/electra/beacon-chain.md?plain=1#L1037-L1039

Thanks @mkalinin ! You're right - I misunderstood the consolidation logic.
Since consolidation balance is capped by effective_balance, the original code is correct. I've updated the PR to only fix two grammar errors (subject-verb agreement on lines 69 and 140).Appreciate the clarification!

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eth-bot eth-bot enabled auto-merge (squash) December 10, 2025 05:48
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit a97898d into ethereum:master Dec 10, 2025
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants