Skip to content

Commit 3e02eba

Browse files
Merge pull request #1197 from sukima/test-each-dataset-type-fix
Add types for object based test.each() datasets
2 parents ec12cd7 + 11f3ef3 commit 3e02eba

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

addon/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ declare global {
274274
interface EachFunction {
275275
<TC extends TestContext, T>(
276276
name: string,
277-
dataset: T[],
277+
dataset: T[] | Record<string, T>,
278278
callback: (this: TC, assert: Assert, data: T) => void | Promise<unknown>
279279
): void;
280280
}

test-types/src/tests.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,16 @@ module('with setup options', function(hooks) {
339339
});
340340

341341
module('methods on test function', function() {
342-
test.each('example with each', [1, 2, 3], async function(assert, number) {
342+
test.each('example with each (array dataset)', [1, 2, 3], async function(assert, number) {
343+
// setup the outer context
344+
this.set('value', 'cat');
345+
346+
await render(hbs`{{number}}`);
347+
348+
assert.strictEqual(number, 1)
349+
});
350+
351+
test.each('example with each (object dataset)', { one: 1, two: 2, three: 3 }, async function(assert, number) {
343352
// setup the outer context
344353
this.set('value', 'cat');
345354

0 commit comments

Comments
 (0)