Skip to content

PropertyTarget: remove transitions on gesture start #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lenemter merged 5 commits into from
Nov 21, 2025
Merged

PropertyTarget: remove transitions on gesture start #2625

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91819b7
WindowClone: don't animate target properties
lenemter Nov 8, 2025
6b66370
Rename back to take_slot
lenemter Nov 8, 2025
6214424
I forgot to add a file...
lenemter Nov 8, 2025
a3e9a93
Merge branch 'main' into lenemter/fix-take-slot
lenemter Nov 20, 2025
918559a
PropertyTarget: remove transitions on gesture start
lenemter Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/Gestures/PropertyTarget.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,17 @@ public class Gala.PropertyTarget : Object, GestureTarget {
}

public void propagate (UpdateType update_type, GestureAction action, double progress) {
if (target == null || update_type != UPDATE || action != this.action) {
if (target == null || action != this.action) {
return;
}

target.set_property (property, interval.compute (progress));
if (update_type == START && target is Clutter.Actor) {
unowned var target_actor = (Clutter.Actor) target;

// We need to stop any transitions as they may interfere with the gesture
target_actor.remove_transition (property);
} else if (update_type == UPDATE) {
target.set_property (property, interval.compute (progress));
}
}
}