Use delete-trailing-whitespace-mode when available
#382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monnier
force-pushed
the
delete-trailing-whitespace-mode
branch
from
41204b6 to
df1cb8d
Compare
(editorconfig-trim-whitespaces-mode): Use `delete-trailing-whitespace-mode` when available. Improve `:type`. (editorconfig-properties-hash): Use `defvar-local`. Remove misleading statement in the docstring. * ert-tests/editorconfig-tests.el (test-trim-trailing-ws): Adjust test. * editorconfig-fnmatch.el (editorconfig-fnmatch--cache-hashtable): Use `defconst`. (editorconfig-fnmatch--do-translate): Don't backslash escape `-` and `,` in regexps (breaks new regexp extensions).
monnier
force-pushed
the
delete-trailing-whitespace-mode
branch
from
df1cb8d to
6055a0d
Compare
xuhdev
reviewed
Nov 27, 2025
| (while (< index length) | ||
| (if (and (not is-escaped) | ||
| (string-match "[^]\\*?[{},/-]+" | ||
| (string-match "[^]\\*?[{},/]+" |
Collaborator
Author
There was a problem hiding this comment.
So we don't need to handle ?- in the cl-case, since it's not special at all. If we don't remove it there, then we need to keep
(?- "-")
instead or removing
(?- (if in-brackets "-" "\\-"))
xuhdev
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might as well.