Allow injection of an HTTP client

[mark-dr]

Using undici is a great choice, but bundling it with the app could be offputting for anyone who's currently using e.g. axios, got, or pure Node HTTP calls (or even just a different version of undici). For those folks, it'd be better if:

• undici is an optional peer dependency
• when creating a DockerClient, we can provide our own network client implementation; otherwise it defaults to your undici-based implementation

[mark-dr]

It would also help with problems like this: #55 (comment)

[ndeloof]

Agree this would be nice to offer maximum flexibility here.
I wonder anyway how we could define a portable API for an arbitrary HTTP client, as DockerClient need to process HTTP response and (AFAICT) each HTTP library bring its own "response" type

[mark-dr]

True, but I'm guessing you only need a small subset of that - maybe just the status code, headers and response body (in JSON or stream form)?

[ndeloof]

indeed, do you have in mind any comparable SDK which offers such flexibility ?

[mark-dr]

Sure - for instance, see "Customizing the fetch client" in the openai package's readme.

[ndeloof]

so openapi relies on what seems to be a hack: https://github.com/openai/openai-node/blob/master/src/internal/types.ts#L66-L87
I'm not the one who can decide this is the way to go or any cleaner (?) alternative exists.

[mark-dr]

Yeah, I wouldn't use that approach - I'd just define and export a minimal HttpClient/fetch interface, provide an Undici-based implementation, and allow the consumer to pass in an instance when creating the DockerClient. If they don't, the Undici one is implicitly used (and the library fails if undici isn't available).

[ndeloof]

Two challenges to be considered:

1. fetch isn't used by node-sdk as a classic API client would do: as docker endpoint can be unix/http/https/ssh the endpoint resolution is not based on request URL, or Host header. So an alternative implementation isn't as simple as a reference to fetch method from selected HTTP client dependency
2. node-sdk also need support for upgrade which is available in undici but not by node's nor bun's native fetch implementation