Skip to content

Commit 57e54fc

Browse files
committed
Fix accessors in various DOM elements
1 parent 25f9527 commit 57e54fc

File tree

2 files changed

+25
-14
lines changed

2 files changed

+25
-14
lines changed

lib/src/html/dom/element_subclasses.dart

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ class AnchorElement extends HtmlElement
6767
_setAttribute('download', value);
6868
}
6969

70-
String? get hreflang => _getAttribute('hreflang');
70+
String get hreflang => _getAttribute('hreflang') ?? '';
7171

72-
set hreflang(String? value) {
72+
set hreflang(String value) {
7373
_setAttribute('hreflang', value);
7474
}
7575

@@ -79,15 +79,15 @@ class AnchorElement extends HtmlElement
7979
_setAttribute('rel', value);
8080
}
8181

82-
String? get target => _getAttribute('target');
82+
String get target => _getAttribute('target') ?? '';
8383

84-
set target(String? value) {
84+
set target(String value) {
8585
_setAttribute('target', value);
8686
}
8787

88-
String? get type => _getAttribute('type');
88+
String get type => _getAttribute('type') ?? '';
8989

90-
set type(String? value) {
90+
set type(String value) {
9191
_setAttribute('type', value);
9292
}
9393

@@ -3332,6 +3332,19 @@ class VideoElement extends MediaElement implements CanvasImageSource {
33323332

33333333
VideoElement._(Document ownerDocument) : super._(ownerDocument, 'VIDEO');
33343334

3335+
String get currentSrc => _getAttribute('currentsrc') ?? '';
3336+
3337+
set currentSrc(String value) {
3338+
_setAttribute('currentsrc', value);
3339+
}
3340+
3341+
num get currentTime =>
3342+
_getAttributeNum('currenttime', defaultValue: 0.0) ?? 0.0;
3343+
3344+
set currentTime(num value) {
3345+
_setAttributeNum('currenttime', value);
3346+
}
3347+
33353348
num get duration => 0;
33363349

33373350
bool get ended => false;

test/src/html/dom/node.dart

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,9 @@ void _testNode() {
3737
test('replaceWith', () {
3838
final e0 = Element.tag('e0')..appendText('e0-text');
3939
final e1 = Element.tag('e1')..appendText('e1-text');
40-
final e2 = Element.tag('e2')..append(
41-
Element.tag('e2c1')
42-
)..append(
43-
Element.tag('e2c2')
44-
);
40+
final e2 = Element.tag('e2')
41+
..append(Element.tag('e2c1'))
42+
..append(Element.tag('e2c2'));
4543
final root = Element.tag('sometag')
4644
..setAttribute('k', 'v')
4745
..append(e0)
@@ -101,9 +99,9 @@ void _testNode() {
10199
expect(replacement.previousNode, isNull);
102100
expect(replacement.nextNode, isNotNull);
103101
expect(
104-
root.outerHtml,
105-
equals(
106-
'<sometag k="v"><e2c1></e2c1>e1-replaced<e2><e2c2></e2c2></e2></sometag>'));
102+
root.outerHtml,
103+
equals(
104+
'<sometag k="v"><e2c1></e2c1>e1-replaced<e2><e2c2></e2c2></e2></sometag>'));
107105
}
108106
});
109107
test('replaceWith when the node has no parent', () {

0 commit comments

Comments
 (0)