Fixes support for bigger report File

partially reverts 06d0488

Author: damianszczepanik

src/main/java/net/masterthought/cucumber/ReportBuilder.java

@@ -106,10 +106,6 @@ public Reportable generateReports() {
             // add metadata info sourced from files
             reportParser.parseClassificationsFiles(configuration.getClassificationFiles());
 
-            StreamReadConstraints defaultStreamReadConstraints = StreamReadConstraints.defaults();
-            StreamReadConstraints streamReadConstraints = StreamReadConstraints.builder().maxStringLength(configuration.getMaxStreamStringLength()).build();
-            StreamReadConstraints.overrideDefaultStreamReadConstraints(streamReadConstraints);
-
             // parse json files for results
             List<Feature> features = reportParser.parseJsonFiles(jsonFiles);
             reportResult = new ReportResult(features, configuration);
@@ -123,9 +119,6 @@ public Reportable generateReports() {
             // Collect and generate pages in a single pass
             generatePages(trends);
 
-            // reset to default configuration
-            StreamReadConstraints.overrideDefaultStreamReadConstraints(defaultStreamReadConstraints);
-
             return reportable;
 
             // whatever happens we want to provide at least error page instead of incomplete report or exception

src/main/java/net/masterthought/cucumber/ReportParser.java

@@ -11,6 +11,9 @@
 import java.util.List;
 import java.util.Objects;
 
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.JsonFactoryBuilder;
+import com.fasterxml.jackson.core.StreamReadConstraints;
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.InjectableValues;
 import com.fasterxml.jackson.databind.JsonMappingException;
@@ -22,10 +25,10 @@
 import org.apache.commons.configuration2.builder.FileBasedConfigurationBuilder;
 import org.apache.commons.configuration2.builder.fluent.Parameters;
 import org.apache.commons.configuration2.ex.ConfigurationException;
+import org.apache.commons.lang3.ArrayUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.apache.commons.lang3.ArrayUtils;
 
 /**
  * Takes <code>json</code> files and converts them into objects used for report generation.
@@ -36,12 +39,18 @@ public class ReportParser {
 
     private static final Logger LOG = LoggerFactory.getLogger(ReportParser.class);
 
-    private final ObjectMapper mapper = new ObjectMapper();
+    private final ObjectMapper mapper;
     private final Configuration configuration;
 
     public ReportParser(Configuration configuration) {
         this.configuration = configuration;
 
+        StreamReadConstraints streamReadConstraints = StreamReadConstraints.builder()
+                .maxStringLength(configuration.getMaxStreamStringLength()).build();
+        JsonFactory factoryBuilder = new JsonFactoryBuilder()
+                .streamReadConstraints(streamReadConstraints).build();
+
+        mapper = new ObjectMapper(factoryBuilder);
         mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
         // this prevents printing eg. 2.20 as 2.2
         mapper.enable(DeserializationFeature.USE_BIG_DECIMAL_FOR_FLOATS);

src/test/java/net/masterthought/cucumber/ReportBuilderTest.java

@@ -14,7 +14,6 @@
 import java.util.Collections;
 import java.util.List;
 
-import com.fasterxml.jackson.core.StreamReadConstraints;
 import net.masterthought.cucumber.generators.OverviewReport;
 import net.masterthought.cucumber.json.Feature;
 import org.apache.commons.io.FileUtils;
@@ -165,24 +164,6 @@ public File getEmbeddingDirectory() {
         assertThat(result).isNull();
     }
 
-    @Test
-    void generateReports_resetsDefaultStreamReadConstraints() {
-
-        // given
-        StreamReadConstraints defaultStreamReadConstraints = StreamReadConstraints.defaults();
-        List<String> jsonReports = Arrays.asList(ReportGenerator.reportFromResource(ReportGenerator.SAMPLE_JSON));
-
-        Configuration configuration = new Configuration(reportDirectory, "constraintsProject");
-        configuration.setMaxStreamStringLength(defaultStreamReadConstraints.getMaxStringLength() + 1);
-        ReportBuilder builder = new ReportBuilder(jsonReports, configuration);
-
-        // when
-        builder.generateReports();
-
-        // then
-        assertThat(StreamReadConstraints.defaults()).isEqualTo(defaultStreamReadConstraints);
-    }
-
     @Test
     void copyStaticResources_CopiesRequiredFiles() throws Exception {