-
-
Notifications
You must be signed in to change notification settings - Fork 18
GHA: misc maintenance #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86afc26 to
6d4a51d
Compare
Detected by actionlint:
```
build_master_multi.yml:18:15: property "build" is not defined in object type {install_latest: bool} [expression]
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some workflows don't test in a PR. I tried making sure all modifications
were tested elsewhere or locally, but breaking something is not out of
possibility.
package: writeperms.cosign.pub.The file is in the git repo root.
aptperformance.aptlog noise.secrets.GITHUB_TOKENovergithub.token.To match other curl repos and highlight its a secret.
${{ matrix.build.name }}with static names.
message:
redhat-actions/podman-login.Tested OK via
build_ci_multi_images.redhat-actions/podman-login.https://github.com/curl/curl-container/pull/94/files?w=1
A bunch of ideas I did not implement in this PR:
redhat-actions/podman-loginaction withpodman logincommand for ghcr.io logins.They do the same, though our command invocation is a bit more secure.
The action logs out, which is a plus, though it's already not done for podman/docker acounts.
It'd allow dropping this actions dependencies and easier to replicate the logic locally.
github.actorwithgithub.repository_owner(=curl)? GH token works with both.sigstore/cosign-installeraction with Linuxbrew. not pinned, with its upsides and downsides.To allow dropping this actions dependencies and easier to replicate the logic locally.
With this removed the Settings / Actions / General exceptions could be deleted.