feat: allow query validator-historical-rewards for distribution #25650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25650 +/- ##
==========================================
+ Coverage 70.42% 70.46% +0.03%
==========================================
Files 830 830
Lines 54052 54134 +82
==========================================
+ Hits 38068 38146 +78
- Misses 15984 15988 +4
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
aljo242
reviewed
Dec 8, 2025
| replace github.com/cosmos/cosmos-sdk => ../ | ||
| replace ( | ||
| cosmossdk.io/api => ../api | ||
| cosmossdk.io/x/tx => ../x/tx |
Contributor
Author
There was a problem hiding this comment.
need replace api in systemtest, and we need to avoid dep like
systemtests git:(distr_cli) go mod why cosmossdk.io/api/cosmos/group/v1
# cosmossdk.io/api/cosmos/group/v1
cosmossdk.io/systemtests
github.com/cosmos/cosmos-sdk/codec/types
cosmossdk.io/x/tx/signing
cosmossdk.io/x/tx/signing.test
cosmossdk.io/api/cosmos/group/v1
| // Below are the long-lived replace of the SimApp | ||
| replace ( | ||
| cosmossdk.io/api => ../api | ||
| cosmossdk.io/x/tx => ../x/tx |
Contributor
Author
There was a problem hiding this comment.
autocli need latest api to work
| } | ||
|
|
||
| // ValidatorHistoricalRewards queries historical rewards for a validator at a specific period | ||
| func (k Querier) ValidatorHistoricalRewards(ctx context.Context, req *types.QueryValidatorHistoricalRewardsRequest) (*types.QueryValidatorHistoricalRewardsResponse, error) { |
Contributor
There was a problem hiding this comment.
all of these functions should be tested 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These queries enable debugging reward calculations by allowing user to inspect internal distribution state without exporting genesis at specific heights. User can query
delegator-starting-infoto get the previous period and stake, then usevalidator-historical-rewardswith that period to retrieve cumulative reward ratios for accurate reward verification.