What is the reason for changing the dynamodb primary key to "id" instead of the default "key" ?

[vesper8]

It seems that out of the box Laravel's Cache expects the primary key to be simply "key"

I created a dynamo table like this (python cdk)

        self.dynamo_table = dynamodb.Table(
            self,
            self.config["dynamoTableId"],
            partition_key=dynamodb.Attribute(
                name="key",
                type=dynamodb.AttributeType.STRING,
            ),
            billing_mode=dynamodb.BillingMode.PAY_PER_REQUEST,
            removal_policy=RemovalPolicy.DESTROY,  # NOT recommended for production code
            time_to_live_attribute="ttl",  # Name of the attribute to hold the TTL timestamp
        )

And this works out of the box with the default dynamodb cache configuration.

But the Bref documentation tell us to add this:

        'attributes' => [
            'key' => 'id',
            'expiration' => 'ttl',
        ]

After which we can set up the dynamodb table like this:

        self.dynamo_table = dynamodb.Table(
            self,
            self.config["dynamoTableId"],
            partition_key=dynamodb.Attribute(
                name="id",
                type=dynamodb.AttributeType.STRING,
            ),
            billing_mode=dynamodb.BillingMode.PAY_PER_REQUEST,
            removal_policy=RemovalPolicy.DESTROY,  # NOT recommended for production code
            time_to_live_attribute="ttl",  # Name of the attribute to hold the TTL timestamp
        )

And this also works.. but I wonder what is the reasoning behind this change? Why not use the default key attribute that Laravel expects?

[mnapoli]

Hi!

Thanks for opening this, I don't think there's any reason at all. Can you point to where Laravel is using key?

We should switch to their default, 100% agree 👍

[vesper8]

@mnapoli Sure. It says so right here in the Laravel Docs:
https://laravel.com/docs/10.x/cache#dynamodb
By default, the partition key should be named key.

[mnapoli]

Perfect, thanks! If you have time to send a quick PR to change the docs that would be awesome!