changes for push url in air gap env #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
Contributor
|
Great job, no security vulnerabilities found in this Pull Request |
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
Contributor
Author
|
Please can we try this again? |
keithhubner
temporarily deployed
to
Production
GitHub Actions
Inactive
keithhubner
temporarily deployed
to
Production
GitHub Actions
Inactive
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
|
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
vgrassia
had a problem deploying
to
Production
GitHub Actions
Failure
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
keithhubner
had a problem deploying
to
Production
GitHub Actions
Failure
vgrassia
had a problem deploying
to
Production
GitHub Actions
Failure
|
mimartin12
approved these changes
May 22, 2025
Collaborator
mimartin12
left a comment
mimartin12
left a comment
There was a problem hiding this comment.
@keithhubner CI is passing now, LGTM 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Change is coming from a customer ticket where they state that if a value is set for the push relay URL when in an air gapped environment:
"I managed to resolve problem by updating record in ConfigMap manually, however that doesn’t seem to be a good solution, since it will be changed on the next Helm upgrade.
Without it, all new user enrollments time out with following error:
“
=> SpanId:1a7223b33e81c28a, TraceId:9e2ded3330d58722549d9251a81d93aa, ParentId:0000000000000000 => ConnectionId:0HN9H8O6I0TVA => RequestPath:/identity/connect/token RequestId:0HN9H8O6I0TVA:00000004 => IpAddress:10.42.202.150 UserAgent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36 DeviceType:9 Origin:9 ClientVersion:2024.12.0
Unable to send POST request to https://push.bitwarden.com/push/register because an access token was unable to be obtained
”
Would you please provide solution to update following record in ConfigMap through Helm values:
globalSettings__pushRelayBaseUri: "https://push.bitwarden.com/push/register"
globalSettings__pushRelayBaseUri: ""
📔 Objective
Allow update to the values file to specify a blank string for the globalSettings__pushRelayBaseUri env var
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes