Add an accept header in JSON request to help 3rd party services like localstack (#1721)

jderusse · web-flow · commit c272f9000c0c · 2024-06-05T21:12:02.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 ### Changed
 
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
 - AWS enhancement: Documentation updates.
 
 ## 2.2.0
diff --git a/src/Input/GetCalculationExecutionRequest.php b/src/Input/GetCalculationExecutionRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetCalculationExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetCalculationExecutionStatusRequest.php b/src/Input/GetCalculationExecutionStatusRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetCalculationExecutionStatus',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetDataCatalogInput.php b/src/Input/GetDataCatalogInput.php
@@ -70,6 +70,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetDataCatalog',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetDatabaseInput.php b/src/Input/GetDatabaseInput.php
@@ -88,6 +88,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetDatabase',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetNamedQueryInput.php b/src/Input/GetNamedQueryInput.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetNamedQuery',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetQueryExecutionInput.php b/src/Input/GetQueryExecutionInput.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetQueryExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetQueryResultsInput.php b/src/Input/GetQueryResultsInput.php
@@ -87,6 +87,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetQueryResults',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetSessionRequest.php b/src/Input/GetSessionRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetSession',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetSessionStatusRequest.php b/src/Input/GetSessionStatusRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetSessionStatus',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetTableMetadataInput.php b/src/Input/GetTableMetadataInput.php
@@ -105,6 +105,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetTableMetadata',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetWorkGroupInput.php b/src/Input/GetWorkGroupInput.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.GetWorkGroup',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ListDatabasesInput.php b/src/Input/ListDatabasesInput.php
@@ -103,6 +103,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.ListDatabases',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ListNamedQueriesInput.php b/src/Input/ListNamedQueriesInput.php
@@ -85,6 +85,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.ListNamedQueries',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ListQueryExecutionsInput.php b/src/Input/ListQueryExecutionsInput.php
@@ -85,6 +85,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.ListQueryExecutions',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ListTableMetadataInput.php b/src/Input/ListTableMetadataInput.php
@@ -134,6 +134,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.ListTableMetadata',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/StartCalculationExecutionRequest.php b/src/Input/StartCalculationExecutionRequest.php
@@ -128,6 +128,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.StartCalculationExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/StartQueryExecutionInput.php b/src/Input/StartQueryExecutionInput.php
@@ -163,6 +163,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.StartQueryExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/StartSessionRequest.php b/src/Input/StartSessionRequest.php
@@ -142,6 +142,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.StartSession',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/StopCalculationExecutionRequest.php b/src/Input/StopCalculationExecutionRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.StopCalculationExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/StopQueryExecutionInput.php b/src/Input/StopQueryExecutionInput.php
@@ -54,6 +54,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.StopQueryExecution',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/TerminateSessionRequest.php b/src/Input/TerminateSessionRequest.php
@@ -55,6 +55,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'AmazonAthena.TerminateSession',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/tests/Unit/Input/GetCalculationExecutionRequestTest.php b/tests/Unit/Input/GetCalculationExecutionRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetCalculationExecution
+            Accept: application/json
 
             {
             "CalculationExecutionId": "145226"
diff --git a/tests/Unit/Input/GetCalculationExecutionStatusRequestTest.php b/tests/Unit/Input/GetCalculationExecutionStatusRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetCalculationExecutionStatus
+            Accept: application/json
 
             {
             "CalculationExecutionId": "125-5rte41"
diff --git a/tests/Unit/Input/GetDataCatalogInputTest.php b/tests/Unit/Input/GetDataCatalogInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.GetDataCatalog
+Accept: application/json
 
 { "Name": "myDataCatalog" }
                 ';
diff --git a/tests/Unit/Input/GetDatabaseInputTest.php b/tests/Unit/Input/GetDatabaseInputTest.php
@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetDatabase
+            Accept: application/json
 
             {
             "CatalogName": "my_catalog_name",
diff --git a/tests/Unit/Input/GetNamedQueryInputTest.php b/tests/Unit/Input/GetNamedQueryInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetNamedQuery
+            Accept: application/json
 
             {
             "NamedQueryId": "test_query"
diff --git a/tests/Unit/Input/GetQueryExecutionInputTest.php b/tests/Unit/Input/GetQueryExecutionInputTest.php
@@ -17,7 +17,8 @@ public function testRequest(): void
         $expected = '
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
-             x-amz-target: AmazonAthena.GetQueryExecution
+            x-amz-target: AmazonAthena.GetQueryExecution
+            Accept: application/json
 
             {
             "QueryExecutionId": "my_query_id25-96"
diff --git a/tests/Unit/Input/GetQueryResultsInputTest.php b/tests/Unit/Input/GetQueryResultsInputTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.GetQueryResults
+Accept: application/json
 
 {
     "QueryExecutionId": "iad-145r55t-11446",
diff --git a/tests/Unit/Input/GetSessionRequestTest.php b/tests/Unit/Input/GetSessionRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetSession
+            Accept: application/json
 
             {
             "SessionId": "iad-aws-Athena23669"
diff --git a/tests/Unit/Input/GetSessionStatusRequestTest.php b/tests/Unit/Input/GetSessionStatusRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetSessionStatus
+            Accept: application/json
 
             {
             "SessionId": "my_session_1236"
diff --git a/tests/Unit/Input/GetTableMetadataInputTest.php b/tests/Unit/Input/GetTableMetadataInputTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetTableMetadata
+            Accept: application/json
 
             {
              "CatalogName": "myCatalogIad",
diff --git a/tests/Unit/Input/GetWorkGroupInputTest.php b/tests/Unit/Input/GetWorkGroupInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.GetWorkGroup
+            Accept: application/json
 
             {
             "WorkGroup": "iadinternational"
diff --git a/tests/Unit/Input/ListDatabasesInputTest.php b/tests/Unit/Input/ListDatabasesInputTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.ListDatabases
+            Accept: application/json
 
             {
     "CatalogName": "IadCatalog",
diff --git a/tests/Unit/Input/ListNamedQueriesInputTest.php b/tests/Unit/Input/ListNamedQueriesInputTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.ListNamedQueries
+Accept: application/json
 
 {
     "NextToken": "iad-9633",
diff --git a/tests/Unit/Input/ListQueryExecutionsInputTest.php b/tests/Unit/Input/ListQueryExecutionsInputTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.ListQueryExecutions
+Accept: application/json
 
 {
     "NextToken": "iad-9633",
diff --git a/tests/Unit/Input/ListTableMetadataInputTest.php b/tests/Unit/Input/ListTableMetadataInputTest.php
@@ -22,6 +22,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.ListTableMetadata
+Accept: application/json
 
 {
 "CatalogName": "iadCatalog",
diff --git a/tests/Unit/Input/StartCalculationExecutionRequestTest.php b/tests/Unit/Input/StartCalculationExecutionRequestTest.php
@@ -30,6 +30,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.StartCalculationExecution
+Accept: application/json
 
 {
     "SessionId": "iad-session-25463",
diff --git a/tests/Unit/Input/StartQueryExecutionInputTest.php b/tests/Unit/Input/StartQueryExecutionInputTest.php
@@ -50,6 +50,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.StartQueryExecution
+Accept: application/json
 
 {
 	"QueryString": "select * from my_table limit 3",
diff --git a/tests/Unit/Input/StartSessionRequestTest.php b/tests/Unit/Input/StartSessionRequestTest.php
@@ -29,6 +29,7 @@ public function testRequest(): void
 POST / HTTP/1.0
 Content-Type: application/x-amz-json-1.1
 x-amz-target: AmazonAthena.StartSession
+Accept: application/json
 
 {
     "Description": "iad international asyncAws",
diff --git a/tests/Unit/Input/StopCalculationExecutionRequestTest.php b/tests/Unit/Input/StopCalculationExecutionRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.StopCalculationExecution
+            Accept: application/json
 
             {
             "CalculationExecutionId": "id14562"
diff --git a/tests/Unit/Input/StopQueryExecutionInputTest.php b/tests/Unit/Input/StopQueryExecutionInputTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.StopQueryExecution
+            Accept: application/json
 
             {
                "QueryExecutionId": "my-query-id-24563"
diff --git a/tests/Unit/Input/TerminateSessionRequestTest.php b/tests/Unit/Input/TerminateSessionRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: AmazonAthena.TerminateSession
+            Accept: application/json
 
             {
             "SessionId": "my-iad-session"
