apk: fix packages return value for apk-tools >= 3 (fix #11264) #11265
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ansibullbot
added
bug
s-hamann
force-pushed
the
fix-apk-parse_for_pacakges
branch
from
c59a238 to
8fdc932
Compare
s-hamann
force-pushed
the
fix-apk-parse_for_pacakges
branch
from
8fdc932 to
d834ee4
Compare
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
felixfontein
reviewed
Dec 8, 2025
Collaborator
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
| packages = [] | ||
| data = stdout.split("\n") | ||
| regex = re.compile(r"^\(\d+/\d+\)\s+\S+\s+(\S+)") | ||
| regex = re.compile(r"^\(\s*\d+/\d+\)\s+\S+\s+(\S+)") |
Collaborator
There was a problem hiding this comment.
Shouldn't this be
Suggested change
| regex = re.compile(r"^\(\s*\d+/\d+\)\s+\S+\s+(\S+)") | |
| regex = re.compile(r"^\s*\(\d+/\d+\)\s+\S+\s+(\S+)") |
so that leading space is removed, and not returned?
| - zsh | ||
| - zsh-calendar | ||
| - zsh-completions | ||
| - zsh-doc |
Collaborator
There was a problem hiding this comment.
Can you shorten this list of packages a bit, to reduce load on our and Alpine's infrastructure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Trivial compatibility fix with
apk-tools>= 3 (part of Alpine 3.23). Compatibility with older versions ofapk-toolsis kept.Issue is that apk now space-pads the number of the package being processed.
Fixes #11264
ISSUE TYPE
COMPONENT NAME
apk
ADDITIONAL INFORMATION
I simply hijacked an existing test case to cover installation of 10 packages instead of only three. Let me know if this should be a separated test and/or if repeated installation/removal should also be covered.