use Syft for decoding CPEs #3058
Open
+20
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2025 10:36
Signed-off-by: Adam Chovanec <[email protected]>
Signed-off-by: Adam Chovanec <[email protected]>
kzantow
reviewed
Nov 18, 2025
| Name: c.Attributes.Product, | ||
| Version: c.Attributes.Version, | ||
| CPEs: []cpe.CPE{c}, | ||
| Type: internal.CPETargetSoftwareToPackageType(c.Attributes.TargetSW), |
Contributor
There was a problem hiding this comment.
Should the CPETargetSoftwareToPackageType get removed now, too since it's in syft?
Contributor
Author
There was a problem hiding this comment.
yeah, I did that in a separate MR for some reason #3057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of new API in Syft for decoding CPEs and enables reading a file with CPEs for scan.
I deleted tests in
grype/pkg/cpe_provider_test.goas they are the same as in syft (see here). It doesn't make sense to me to have the same test the same functionality in two places, but let me know if you want it some other way.