Skip to content

example/queue: Application.make_handler(...) is deprecated #195

@kevinqqnj

Description

@kevinqqnj

Thanks for the good examples.
There's warning when running example/queue:
queue/runner.py:19: DeprecationWarning: Application.make_handler(...) is deprecated, use AppRunner API instead

python 3.7.2
aiozipkin==0.5.0
aiohttp==3.5.4
aiojobs==0.2.2

Checked latest aiohttp doc., maybe need to update like this (it works without warnings):

# /examples/queue/runner.py
def run():
    ...
    fe_handler = web.AppRunner(fe_app)
    be_handler = web.AppRunner(be_app)
    handlers = [fe_handler, be_handler]
    
    loop_run(fe_handler.setup())
    loop_run(be_handler.setup())

    loop_run(loop.create_server(fe_handler.server, host, fe_port))
    loop_run(loop.create_server(be_handler.server, host, be_port))

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions