-
-
Notifications
You must be signed in to change notification settings - Fork 67
Replace permissive URL regex with secure validation in apply form #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Merged
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: jeromehardaway <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix form UX issues based on PR #806 feedback
Replace permissive URL regex with secure validation in apply form
Oct 29, 2025
jeromehardaway
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prework link validation used a permissive regex
/^https?:\/\/.+/that accepts malformed URLs likehttps://orhttp://malformed..url, creating a security vulnerability.Changes
isValidUrl()function using URL constructorpatterntovalidatefor better error handlingImplementation
The
isValidUrl()function leverages the browser's URL constructor to properly validate URLs while maintaining compatibility with legitimate prework hosting platforms.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.