Skip to content

Commit 1d1cce9

Browse files
authored
Update README.md, move contributing to CONTRIBUTING.md and update images (#58)
This pull request includes updates to the README.md file, moves the contributing guidelines to CONTRIBUTING.md, and updates images used in the project.
2 parents 4a90bb1 + 30cfd2f commit 1d1cce9

File tree

14 files changed

+154
-94
lines changed

14 files changed

+154
-94
lines changed

CONTRIBUTING.md

Lines changed: 101 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,101 @@
1+
# 🤝 Contributing to MinionAH
2+
3+
First off, thanks for taking the time to contribute! ❤️
4+
5+
All types of contributions are encouraged and valued. See the [Table of Contents](#-table-of-contents) for different ways to help and details about how this project handles them. Please make sure to read the relevant section before making your contribution. It will make it a lot easier for us maintainers and smooth out the experience for all involved. The community looks forward to your contributions. 🎉
6+
7+
> And if you like the project, but just don't have time to contribute, that's fine. There are other easy ways to support the project and show your appreciation, which we would also be very happy about:
8+
>
9+
> - Star the project
10+
> - Tweet about it
11+
> - Refer this project in your project's readme
12+
> - Share the project with others and tell your friends about it
13+
14+
# 📑 Table of Contents
15+
16+
- [📑 Table of Contents](#-table-of-contents)
17+
- [🧰 Setup for Development](#-setup-for-development)
18+
- [📦 Prerequisites](#-prerequisites)
19+
- [🚀 Getting Started](#-getting-started)
20+
- [🔀 Pull Requests](#-pull-requests)
21+
- [🐛 Issues](#-issues)
22+
23+
# 🧰 Setup for Development
24+
25+
This section will guide you through the process of setting up the project for development.
26+
27+
## 📦 Prerequisites
28+
29+
- [Git](https://git-scm.com/downloads)
30+
- [Node.js](https://nodejs.org/en/) (v20 or higher)
31+
- [pnpm](https://pnpm.js.org/en/installation) (recommended)
32+
- [MongoDB](https://www.mongodb.com/try/download/community) (v7.0 or higher) (this project uses MongoDB Atlas, but you can use a local instance if you want)
33+
- [Vercel](https://vercel.com/) (this project uses Vercel for hosting and deployment, so your fork should be Vercel compatible)
34+
35+
## 🚀 Getting Started
36+
37+
1. Clone the repository
38+
39+
```bash
40+
git clone https://github.com/DarthGigi/MinionAH.git
41+
```
42+
43+
2. Go into the directory
44+
45+
```bash
46+
cd MinionAH
47+
```
48+
49+
3. Install the dependencies
50+
51+
```bash
52+
pnpm install
53+
```
54+
55+
4. Add an `.env` file with the same contents as `.env.example` and fill in the values.
56+
57+
5. Run the database initialization script
58+
59+
```bash
60+
pnpx prisma db push && pnpx prisma generate
61+
```
62+
63+
6. Start the development server
64+
65+
```bash
66+
pnpm dev
67+
```
68+
69+
This will get rid of TypeScript errors and warnings.
70+
71+
7. Open `src/routes/api/resetminions/+server.ts`, remove
72+
73+
```js
74+
return new Response(null, {
75+
status: 302,
76+
headers: {
77+
location: "/"
78+
}
79+
});
80+
```
81+
82+
at the top of the file, and open [localhost:5173/api/resetminions](http://localhost:5173/api/resetminions) with your browser to fill the database with all the Hypixel SkyBlock minions and their data.
83+
84+
8. Done! You can now start making changes to the code and see them reflected in the browser.
85+
86+
9. (Optional) You should probably make an account so you can work on stuff where you need to be logged in. You can do this by going to [localhost:5173/login](http://localhost:5173/login) and clicking the "Sign up" button.
87+
88+
# 🔀 Pull Requests
89+
90+
Before making a pull request, please make sure that:
91+
92+
1. Your code is formatted with [Prettier](https://prettier.io/).
93+
2. Your code does not have any TypeScript errors or warnings.
94+
3. Your changes do not break any existing functionality (unless that's the point of the PR).
95+
4. Your code builds successfully locally.
96+
5. Your code builds and deploys successfully on Vercel.
97+
98+
# 🐛 Issues
99+
100+
If you find a bug or have a feature request, please open an issue with the relevant template.
101+
Make sure to check if there is already an issue for it before opening a new one. If there is, you can comment on the existing issue to show your support for it.

README.md

Lines changed: 53 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -3,138 +3,97 @@
33
</p>
44

55
<p align=center>
6-
<img src="https://img.shields.io/github/license/DarthGigi/MinionAH?style=for-the-badge" alt="license">
7-
<img src="https://img.shields.io/github/languages/count/DarthGigi/MinionAH?style=for-the-badge" alt="languages">
8-
<img src="https://img.shields.io/github/languages/top/DarthGigi/MinionAH?style=for-the-badge" alt="top language">
9-
<img src="https://img.shields.io/website?style=for-the-badge&url=https%3A%2F%2Fminionah.com" alt="website status">
6+
<img src="https://img.shields.io/github/license/DarthGigi/MinionAH?style=for-the-badge" alt="license">
7+
<img src="https://img.shields.io/github/languages/count/DarthGigi/MinionAH?style=for-the-badge" alt="languages">
8+
<img src="https://img.shields.io/github/languages/top/DarthGigi/MinionAH?style=for-the-badge" alt="top language">
9+
<img src="https://img.shields.io/website?style=for-the-badge&url=https%3A%2F%2Fminionah.com" alt="website status">
1010
</p>
1111

12+
# Changelog
13+
14+
Looking for the changelog? Check out [CHANGELOG.md](/CHANGELOG.md)!
15+
1216
# 📑 Table of Contents
1317

1418
- [📑 Table of Contents](#-table-of-contents)
1519
- [🏦 MinionAH](#-minionah)
20+
- [🏠 Home](#-home)
21+
- [👤 Profile](#-profile)
22+
- [🛠️ Creating Minions](#️-creating-minions)
1623
- [💰 Purchasing Minions](#-purchasing-minions)
17-
- [🤔 Why MinionAH](#-why-minionah)
18-
- [🌐 Community](#-community)
19-
- [📜 Credits](#-credits)
24+
- [🤔 Why MinionAH](#-why-minionah)
25+
- [🌐 Community](#-community)
26+
- [📜 Credits](#-credits)
27+
2028
- [🔒 Privacy/Data](#-privacydata)
2129
- [🤝 Contributing](#-contributing)
22-
- [🧰 Setup for Development](#-setup-for-development)
23-
- [📝 License](#-license)
30+
- [📝 License](#-license)
2431

2532
# 🏦 MinionAH
2633

2734
MinionAH is a seamless and easy-to-use way to purchase and sell Hypixel SkyBlock minions with a beautiful interface. It's designed with precision and a good user experience in mind and is perfect for _any_ SkyBlock player.
2835

29-
MinionAH makes it easy to sell minions and view information about minions with a glance.
30-
31-
![MinionAH](/static/assets/images/showcase1.png)
32-
As shown, it's easy to find minions on MinionAH. But it even gets better with a beautiful hover animation. Clicking the card or the user will open the seller's Discord profile. Clicking the minion will open the wiki page of the minion for even more information.
33-
34-
![Minion Animation](/static/assets/images/showcase2.gif)
35-
It's also super easy to search for minions on MinionAH.
36-
37-
![Minion Animation](/static/assets/images/showcase3.gif)
38-
After logging in with Discord, you can access your profile page where you can sell a minion, see a list of your minions and delete minions you sell or no longer want to sell.
39-
40-
![Minion Animation](/static/assets/images/showcase4.gif)
41-
Creating minions is very easy too. You simply select a minion from the minion dropdown, or just start typing the name of the minion. Next, select the tier and fill how many minions you're selling and the price (for each). Finally, just click Create and you're done!
36+
MinionAH makes it easy to sell minions and view information about minions at a glance.
4237

43-
![Minion Animation](/static/assets/images/showcase5.gif)
38+
## 🏠 Home
4439

45-
## 💰 Purchasing Minions
40+
![MinionAH](/static/assets/images/readme/overview.png)
41+
As shown, it's easy to find minions on MinionAH. But it gets even better, when you hover over a minion or a user, more info about them will show up. Clicking the user will open their profile. Clicking the minion will open the wiki page of the minion for even more information.
42+
![User Hover](/static/assets/images/readme/user-hover.png)
4643

47-
The way you buy minions is essentially the same as you would if using Discord servers to sell your minions. You simply DM the user that sells the minion and discuss when you both can get online and trade. You can click on the user to start a chat with them.
44+
---
4845

49-
## 🤔 Why MinionAH
46+
![Minion Hover](/static/assets/images/readme/minion-hover.png)
5047

51-
I made MinionAH because (at the time of writing) you can't sell Minions in the in-game Auction House. Instead, you need to join various Discord servers and post "ad" messages in the right channels or in the in-game chat. In both cases, the message also "disappears" since so many others are doing the same thing.
52-
That's why I thought, "There must surely be a better way to tackle this problem." So I decided to work on MinionAH.
48+
## 👤 Profile
5349

54-
## 🌐 Community
50+
After signing up with [mc-auth](https://mc-auth.com), you can access your profile page where you can create a new minion listing, see a list of your minions, and delete minions you sold or no longer want to sell.
5551

56-
<a href="https://discord.minionah.com">
57-
<img src="https://discordapp.com/api/guilds/1133219625497284638/widget.png?style=banner3" alt="Discord Server" />
58-
</a>
52+
![Profile](/static/assets/images/readme/profile.png)
5953

60-
## 📜 Credits
54+
## 🛠️ Creating Minions
6155

62-
[Gigi](https://github.com/DarthGigi) - Main Developer
56+
Creating minions is very easy. You simply select a minion from the minion dropdown or just start typing the name of the minion. Next, select the tier and fill in how many minions you're selling and the price (for each). Finally, just click Create and you're done!
6357

64-
# 🔒 Privacy/Data
58+
![Select Minion](/static/assets/images/readme/select-minion.png)
6559

66-
Here is all the data stored with MinionAH (more technical stuff incoming):​
60+
---
6761

68-
- IP: Whether you are logged in or not, we store your IP on the server (not the database) solely for rate-limiting purposes. You can make 60 requests per minute (searching/filtering, loading more minions, logging in, basically every time you do something on the website even loading the website, is a request). This is to prevent any malicious users from spamming requests and overloading the database and hosting provider (in which case we would need to pay more). Again, since this is not stored in the database but the server itself, not even I can see your IP.​
62+
![Create Minion](/static/assets/images/readme/create-minion.png)
6963

70-
If you log in via Discord, I get "access" to your Discord account, but the "access" is very limited (this is how every "Sign in via Discord" app/bot/website works).
71-
Basically, Discord sends an extremely limited authentication token for your account so we can request the necessary info about your account for the website. Here is what info we request from Discord and store in the database:
72-
73-
- Discord ID
74-
- Username
75-
- Avatar
76-
- Banner
77-
- Accent color
78-
- Locale (not doing anything with it, but might add localization support later)
79-
- Date/time of last logged in (not data that Discord gives me, but needed so that I can delete accounts that were last logged in an X amount of days/months ago, not sure how long I should make this yet).
80-
81-
# 🤝 Contributing
82-
83-
Feel free to contribute to MinionAH! Just make a Pull Request.
84-
85-
## 🧰 Setup for Development
86-
87-
1. Clone the repository
88-
89-
```bash
90-
git clone https://github.com/DarthGigi/MinionAH.git
91-
```
92-
93-
2. Go into the directory
94-
95-
```bash
96-
cd MinionAH
97-
```
64+
## 💰 Purchasing Minions
9865

99-
3. Install the dependencies
66+
The way you buy minions is essentially the same as if you would be using Discord servers to sell your minions.
67+
You simply message the user who sells the minion and discuss when you both can get online and trade.
10068

101-
```bash
102-
pnpm install
103-
```
69+
![Chat](/static/assets/images/readme/chat.png)
10470

105-
4. Add an `.env` file with the same contents as `.env.example` and fill in the values.
71+
# 🤔 Why MinionAH
10672

107-
5. Run the database initialization script
73+
I (Gigi) made MinionAH because (at the time of writing) you can't sell Minions in the in-game Auction House. Instead, you need to join various Discord servers and post "ad" messages in the right channels or the in-game chat. In both cases, the message also "disappears" since so many others are doing the same thing.
74+
That's why I thought, "There must surely be a better way to tackle this problem." So I decided to work on MinionAH.
10875

109-
```bash
110-
pnpx prisma db push
111-
```
76+
# 🌐 Community
11277

113-
and
78+
<p align=center>
79+
<a href="https://discord.minionah.com">
80+
<img src="https://discordapp.com/api/guilds/1133219625497284638/widget.png?style=banner3" alt="Discord Server" />
81+
</a>
82+
</p>
11483

115-
```bash
116-
pnpx prisma generate
117-
```
84+
# 📜 Credits
11885

119-
6. Start the development server
86+
[Gigi](https://github.com/DarthGigi) - Main Developer
12087

121-
```bash
122-
pnpm dev
123-
```
88+
# 🔒 Privacy/Data
12489

125-
7. Open `src/routes/api/resetminions/+server.ts`, remove
90+
Check out our [Privacy Policy](https://newsroom.minionah.com/privacy-policy) and [Terms of Service](https://newsroom.minionah.com/terms-of-service) for more information.
91+
These will be updated when needed, unlike this README.
12692

127-
```js
128-
return new Response(null, {
129-
status: 302,
130-
headers: {
131-
location: "/"
132-
}
133-
});
134-
```
93+
# 🤝 Contributing
13594

136-
and open [localhost:5127/api/loadMinions](http://localhost:5127/api/loadMinions) with your browser to fill the database with minions.
95+
Contributions are welcome! Please read [CONTRIBUTING.md](/CONTRIBUTING.md) for more information.
13796

138-
## 📝 License
97+
# 📝 License
13998

140-
[GNU AGPLv3](https://github.com/DarthGigi/MinionAH/blob/main/LICENSE)
99+
This project is licensed under the [GNU AGPLv3](https://github.com/DarthGigi/MinionAH/blob/main/LICENSE) license.
112 KB
Loading
117 KB
Loading
98.9 KB
Loading
1.31 MB
Loading
1.98 MB
Loading
122 KB
Loading
90.4 KB
Loading

static/assets/images/showcase1.png

-158 KB
Binary file not shown.

0 commit comments

Comments
 (0)