-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
featureNew featureNew feature
Description
From #257 (comment)
Don't filter on configured properties here:
WikibaseFacetedSearch/src/Application/StatementListTranslator.php
Lines 46 to 56 in 1ae22cf
| private function getPropertiesToIndex( ItemId $itemType ): array { | |
| $properties = array_values( | |
| array_map( | |
| fn( FacetConfig $config ) => $config->propertyId, | |
| $this->config->getFacetConfigForItemType( $itemType ) | |
| ) | |
| ); | |
| $properties[] = $this->config->getItemTypeProperty(); | |
| return $properties; | |
| } |
Instead, allow all properties to be indexed, but use the null return value in https://github.com/ProfessionalWiki/WikibaseFacetedSearch/blob/master/src/Application/DataValueTranslator.php to skip unsupported properties.
Optionally, add config to enable/disable automatic indexing.
Metadata
Metadata
Assignees
Labels
featureNew featureNew feature