logger.max_file_size = 0 does not allow unlimited logs

[atomizable]

Config looks alright...

[root@server riak]# riak chkconfig
config is OK
-config /var/lib/riak/generated.conf/app.2025.07.07.07.18.06.config -args_file /var/lib/riak/generated.conf/vm.2025.07.07.07.18.06.args -vm_args /var/lib/riak/generated.conf/vm.2025.07.07.07.18.06.args
[root@server riak]#

## The maximum size of a single log file. Total size used for log files will
## be max_file_size * max_files.
##
## Default: 1MB
##
## Acceptable values:
##   - a byte size with units, e.g. 10GB
logger.max_file_size = 0

But...

[root@server riak]# riak console
Exec: /usr/lib64/riak/erts-13.2.2.14/bin/erlexec -boot /usr/lib64/riak/releases/3.2.5/start -mode embedded -boot_var SYSTEM_LIB_DIR /usr/lib64/riak/lib -config /usr/lib64/riak/releases/3.2.5/sys.config -args_file /var/lib/riak/generated.conf/vm.2025.07.07.07.07.13.args -- console
Root: /usr/lib64/riak
/usr/lib64/riak
Erlang/OTP 25 [erts-13.2.2.14] [source] [64-bit] [smp:48:48] [ds:48:48:10] [async-threads:64] [jit:ns]

=ERROR REPORT==== 7-Jul-2025::07:17:05.420151 ===
Invalid logger handler config: {kernel,
                                {handler_not_added,
                                 {invalid_config,logger_std_h,
                                  #{max_no_bytes => 0}}}}
=CRASH REPORT==== 7-Jul-2025::07:17:05.422466 ===
  crasher:
    initial call: application_master:init/4
    pid: <0.1314.0>
    registered_name: []
    exception exit: {bad_return,
                     {{kernel,start,[normal,[]]},
                      {'EXIT',
                       {{badmatch,
                         {error,
                          {bad_config,
                           {handler,
                            {kernel,
                             {handler_not_added,
                              {invalid_config,logger_std_h,
                               #{max_no_bytes => 0}}}}}}}},
                        [{kernel,start,2,[{file,"kernel.erl"},{line,38}]},
                         {application_master,start_it_old,4,
                          [{file,"application_master.erl"},{line,293}]}]}}}}
      in function  application_master:init/4 (application_master.erl, line 142)
    ancestors: [<0.1313.0>]
    message_queue_len: 1
    messages: [{'EXIT',<0.1315.0>,normal}]
    links: [<0.1313.0>,<0.1312.0>]
    dictionary: []
    trap_exit: true
    status: running
    heap_size: 376
    stack_size: 28
    reductions: 167
  neighbours:

=INFO REPORT==== 7-Jul-2025::07:17:05.423014 ===
    application: kernel
    exited: {bad_return,
             {{kernel,start,[normal,[]]},
              {'EXIT',
               {{badmatch,
                 {error,
                  {bad_config,
                   {handler,
                    {kernel,
                     {handler_not_added,
                      {invalid_config,logger_std_h,#{max_no_bytes => 0}}}}}}}},
                [{kernel,start,2,[{file,"kernel.erl"},{line,38}]},
                 {application_master,start_it_old,4,
                  [{file,"application_master.erl"},{line,293}]}]}}}}
    type: permanent

{"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{bad_return,{{kernel,start,[normal,[]]},{'EXIT',{{badmatch,{error,{bad_config,{handler,{kernel,{handler_not_added,{invalid_config,logger_std_h,#{max_no_bytes => 0}}}}}}}},[{kernel,start,2,[{file,\"kernel.erl\"},{line,38}]},{application_master,start_it_old,4,[{file,\"application_master.erl\"},{line,293}]}]}}}}}"}
Kernel pid terminated (application_controller) ({application_start_failure,kernel,{bad_return,{{kernel,start,[normal,[]]},{'EXIT',{{badmatch,{error,{bad_config,{handler,{kernel,{handler_not_added,{invalid_config,logger_std_h,#{max_no_bytes => 0}}}}}}}},[{kernel,start,2,[{file,"kernel.erl"},{line,38}]},{application_master,start_it_old,4,[{file,"application_master.erl"},{line,293}]}]}}}}})

It falls over citing:

{invalid_config,logger_std_h,#{max_no_bytes => 0}}}}}}}},

I was trying to allow unlimited logs that rotate at the end of the day.

[atomizable]

Dilatory, but worth noting, adding a 'unit' does not help the problem: logger.max_file_size = 0MB

[martinsumner]

Looking at the config of logger max_no_bytes has to be either a positive integer or infinity (which would get what you want): https://www.erlang.org/doc/apps/kernel/logger_std_h.html

The riak.schema requires a bytesize datatype - and I think this will require an integer.

The issue is not with cuttlefish itself, but with the validation in the riak schema which doesn't allow for infinity. There's no workaround at present other than setting an extremely large size.

There is some work pending to re-do how Riak/logger work together. @tburghart - could infinity size be added as part of this?

[tburghart]

I don't think supporting infinity in cuttlefish is the right solution here.
Instead, the schema should just default to not specifying this value, adding it only if explicitly configured.
It defaults to infinity in the handler, so simply leaving it out will do The Right Thing™ - the problem is the assumption that it needs to be supplied in the first place (presumably a lager-ism).

As an interim fix for @atomizable just putting in a big number that you'll never hit (maybe "1GB"?) should get you past it with the current release, I would think.