Skip to content

Commit 1050b75

Browse files
committed
Merge branch 'main' of github.com:NativeScript/ns-v8ios-runtime into fix/block-leaks-release
2 parents c0345e8 + 0c4b819 commit 1050b75

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/npm_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ jobs:
172172
- uses: actions/download-artifact@v3
173173
with:
174174
name: NativeScript-dSYMs
175-
path: dist
175+
path: dist/dSYMs
176176
- name: Zip dSYMs
177177
working-directory: dist/dSYMs
178178
run: find . -maxdepth 1 -name '*.dSYM' -print | xargs -I@ zip -r @.zip @

NativeScript/runtime/Timers.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
161161
v8::Local<v8::Function> cb = task->callback_.Get(isolate);
162162
v8::Local<v8::Context> context = cb->GetCreationContextChecked();
163163
Context::Scope context_scope(context);
164-
TryCatch tc(isolate);
165164
auto argc = task->args_.get() == nullptr ? 0 : task->args_->size();
166165
if (argc > 0) {
167166
Local<Value> argv[argc];
@@ -172,11 +171,11 @@ void TimerCallback(CFRunLoopTimerRef timer, void *info) {
172171
} else {
173172
(void)cb->Call(context, context->Global(), 0, nullptr);
174173
}
175-
tc.ReThrow();
176174

177175
if (!task->repeats_) {
178176
data->state->removeTask(task);
179177
}
178+
180179
}
181180

182181
void Timers::SetTimer(const v8::FunctionCallbackInfo<v8::Value>& args, bool repeatable) {

0 commit comments

Comments
 (0)