fix(backend): rename retriver directory to retriever #534
Conversation
Fixes typo in directory name and updates all import paths: - Renamed surfsense_backend/app/retriver/ to surfsense_backend/app/retriever/ - Updated imports in db.py - Updated imports in connector_service.py
|
@ankitpasayat is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in the directory name from retriver to retriever and updates all import paths accordingly.
- Renamed directory:
surfsense_backend/app/retriver/→surfsense_backend/app/retriever/ - Updated import statements in
db.pyandconnector_service.pyto use the corrected path - Moved retriever implementation files to the corrected directory structure
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| surfsense_backend/app/services/connector_service.py | Updated imports from app.retriver to app.retriever |
| surfsense_backend/app/db.py | Updated imports from app.retriver to app.retriever |
| surfsense_backend/app/retriever/chunks_hybrid_search.py | Moved file with chunk-based hybrid search implementation |
| surfsense_backend/app/retriever/documents_hybrid_search.py | Moved file with document-based hybrid search implementation |
| surfsense_backend/app/retriever/init.py | Added package initializer for retriever module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| from app.retriver.chunks_hybrid_search import ChucksHybridSearchRetriever | ||
| from app.retriver.documents_hybrid_search import DocumentHybridSearchRetriever | ||
| from app.retriever.chunks_hybrid_search import ChucksHybridSearchRetriever |
There was a problem hiding this comment.
The imported class name ChucksHybridSearchRetriever contains a spelling error. It should be ChunksHybridSearchRetriever (Chunks, not Chucks). This import should reference the correctly spelled class name.
| from app.config import config | ||
| from app.retriver.chunks_hybrid_search import ChucksHybridSearchRetriever | ||
| from app.retriver.documents_hybrid_search import DocumentHybridSearchRetriever | ||
| from app.retriever.chunks_hybrid_search import ChucksHybridSearchRetriever |
There was a problem hiding this comment.
The imported class name ChucksHybridSearchRetriever contains a spelling error. It should be ChunksHybridSearchRetriever (Chunks, not Chucks). This import should reference the correctly spelled class name.
| from app.retriever.chunks_hybrid_search import ChucksHybridSearchRetriever | |
| from app.retriever.chunks_hybrid_search import ChunksHybridSearchRetriever |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on 601489b..b30f53b
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (2)
• surfsense_backend/app/db.py
• surfsense_backend/app/services/connector_service.py
⏭️ Files skipped (3)
| Locations |
|---|
surfsense_backend/app/retriever/__init__.py |
surfsense_backend/app/retriever/chunks_hybrid_search.py |
surfsense_backend/app/retriever/documents_hybrid_search.py |
|
@ankitpasayat Thanks 👍 |
2 participants
Fixes typo in directory name and updates all import paths:
Description
Motivation and Context
FIX #
Screenshots
API Changes
Change Type
Testing Performed
Checklist
High-level PR Summary
This pull request fixes a typo in the directory name by renaming
retrivertoretrieverand updates all corresponding import paths across the backend codebase. The change involves renaming three files in theretrievermodule and updating the import statements in two files (db.pyandconnector_service.py) that reference these modules.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_backend/app/retriever/__init__.pysurfsense_backend/app/retriever/chunks_hybrid_search.pysurfsense_backend/app/retriever/documents_hybrid_search.pysurfsense_backend/app/db.pysurfsense_backend/app/services/connector_service.py