fix: Fix uint8 NaN value https://github.com/Koenkk/zigbee-herdsman/issues/1498
#1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Sep 22, 2025
Nerivec
reviewed
Sep 22, 2025
src/zspec/zcl/buffaloZcl.ts
Outdated
| return Number.isNaN(length) ? Buffer.from([]) : this.readBuffer(length); | ||
|
|
||
| // See UINT8_TMP_FIX | ||
| return this.readBuffer(length); |
Collaborator
There was a problem hiding this comment.
Have to keep the check here, but without NaN use:
return length < 0xff ? this.readBuffer(length) : Buffer.from([]); // non-valuesame for char_str, and long versions (with 0xffff).
Owner
Author
There was a problem hiding this comment.
Updated readCharStr and readOctetStr. I don't think readLongOctetStr has to be updated because it's reading a uint16? (which will still return NaN)
Nerivec
approved these changes
Sep 23, 2025
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temp fix until #1503 is ready.
Fixes:
UINT8doesn't allow0xff(255) as value anymore which breaks code #1498