Setting the wrong alignment value when loading a Buffer Reference through a Buffer Reference

[spencer-lunarg]

https://godbolt.org/z/j8jGvsnMh

layout(buffer_reference) buffer S4;

layout(buffer_reference, buffer_reference_align = 8, std430) readonly buffer S3 {
    S4 e;
};

// Set buffer_reference_align to 8 and it generates valid code
layout(buffer_reference, buffer_reference_align = 4, std430) readonly buffer S4 {
    uint f;
};

void main() {    
    S3 x;
    S4 y = x.e;
}

Seems currently glslang sets the x.e as an OpLoad with a result type of OpTypePointer but the Aligned 4 is wrong and should be 8 and produces a spirv-val error (https://godbolt.org/z/sxT1asEdv)

[spencer-lunarg]

this might be a duplicate of #4024

[GabeRundlett]

A potentially more clear example could be the following, as it demonstrates that it's not getting the alignment from what is being assigned into, but instead incorrectly aligning via S4's alignment. In godbolt, this uses Align 1

#version 450
#extension GL_EXT_scalar_block_layout : enable
#extension GL_EXT_buffer_reference : enable
#extension GL_EXT_shader_explicit_arithmetic_types_int64 : enable

layout(buffer_reference, buffer_reference_align = 1) readonly buffer S4;

layout(buffer_reference, buffer_reference_align = 8) readonly buffer S3 {
    S4 e;
};

void main() {    
    S3 x;
    uint64_t y = uint64_t(x.e);
}

[spencer-lunarg]

@GabeRundlett got a fix up here #4089 !