Skip to content

fix: Gate empty result in GATConv #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenianiva wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Gate empty result in GATConv #638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e628595
fix: Gate empty result in GATConv
lenianiva Jan 18, 2026
9b794a9
fix: Handle multiple heads
lenianiva Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions GNNlib/src/layers/conv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,10 @@ function gat_conv(l, g::AbstractGNNGraph, x, e::Union{Nothing, AbstractMatrix} =
_, chout = l.channel
heads = l.heads

Wxi = Wxj = l.dense_x(xj)
Wxi = Wxj = reshape(Wxj, chout, heads, :)

if xi !== xj
Wxi = l.dense_x(xi)
Wxi = reshape(Wxi, chout, heads, :)
end
Wxj = l.dense_x(xj)
Wxj = reshape(Wxj, chout, heads, :)
Wxi = l.dense_x(xi)
Wxi = reshape(Wxi, chout, heads, :)
Comment on lines +127 to +130
Copy link
Member

@CarloLucibello CarloLucibello Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Wxj = l.dense_x(xj)
Wxj = reshape(Wxj, chout, heads, :)
Wxi = l.dense_x(xi)
Wxi = reshape(Wxi, chout, heads, :)
Wxj = l.dense_x(xj)
Wxj = reshape(Wxj, chout, heads, :)
if xi !== xj
Wxi = l.dense_x(xi)
Wxi = reshape(Wxi, chout, heads, :)
else
Wxi = Wxj
end

would work?

Copy link
Contributor Author

@lenianiva lenianiva Jan 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work. It seems like the above example triggers both branches and Zygote gets one branch confused for another. I have seen this kind of behaviour before with Zygote.


# a hand-written message passing
message = Fix1(gat_message, l)
Expand All @@ -142,8 +139,11 @@ function gat_conv(l, g::AbstractGNNGraph, x, e::Union{Nothing, AbstractMatrix} =

if !l.concat
x = mean(x, dims = 2)
width = size(x, 1)
else
width = size(x, 1) * size(x, 2)
end
x = reshape(x, :, size(x, 3)) # return a matrix
x = reshape(x, width, size(x, 3)) # return a matrix
x = l.σ.(x .+ l.bias)

return x
Expand Down Expand Up @@ -194,8 +194,11 @@ function gatv2_conv(l, g::AbstractGNNGraph, x, e::Union{Nothing, AbstractMatrix}

if !l.concat
x = mean(x, dims = 2)
width = size(x, 1)
else
width = size(x, 1) * size(x, 2)
end
x = reshape(x, :, size(x, 3))
x = reshape(x, width, size(x, 3))
x = l.σ.(x .+ l.bias)
return x
end
Expand Down
Loading