Skip to content

Conversation

@botantony
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

Another attempt to fix bottle publishing after adding the typecheck.

Another attempt to fix bottle publishing after adding the typecheck.

Signed-off-by: botantony <[email protected]>
Copilot AI review requested due to automatic review settings December 7, 2025 17:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typecheck error in the GitHub Packages bottle upload functionality by converting a Version object to a string before including it in OCI image annotations.

Key Changes

  • Adds .to_s conversion to the version object when setting the org.opencontainers.image.version annotation
  • Includes an explanatory comment noting that the schema accepts strings for version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we should consider reverting #21192 and just fixing the signatures.

@botantony botantony added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit 70badad Dec 7, 2025
43 checks passed
@botantony botantony deleted the github_packages-schema branch December 7, 2025 20:54
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @botantony!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants