chore(l10n): remove duplicate contact click strings #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

naveensingh merged 2 commits into main from naveensingh/remove-duplicate-strings

Jan 26, 2026

app/src/main/kotlin/org/fossify/contacts/activities/SettingsActivity.kt

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -217,9 +217,9 @@ class SettingsActivity : SimpleActivity() {
  
            binding.settingsOnContactClick.text = getOnContactClickText()

            binding.settingsOnContactClickHolder.setOnClickListener {

                val items = arrayListOf(

                    RadioItem(ON_CLICK_CALL_CONTACT, getString(R.string.call_contact)),

                    RadioItem(ON_CLICK_VIEW_CONTACT, getString(R.string.view_contact)),

                    RadioItem(ON_CLICK_EDIT_CONTACT, getString(R.string.edit_contact))

                    RadioItem(ON_CLICK_CALL_CONTACT, getString(org.fossify.commons.R.string.call_contact)),

                    RadioItem(ON_CLICK_VIEW_CONTACT, getString(org.fossify.commons.R.string.view_contact)),

                    RadioItem(ON_CLICK_EDIT_CONTACT, getString(org.fossify.commons.R.string.edit_contact))

                )

                RadioGroupDialog(this@SettingsActivity, items, config.onContactClick) {

    @@ -231,9 +231,9 @@ class SettingsActivity : SimpleActivity() {
  
        private fun getOnContactClickText() = getString(

            when (config.onContactClick) {

                ON_CLICK_CALL_CONTACT -> R.string.call_contact

                ON_CLICK_VIEW_CONTACT -> R.string.view_contact

                else -> R.string.edit_contact

                ON_CLICK_CALL_CONTACT -> org.fossify.commons.R.string.call_contact

                ON_CLICK_VIEW_CONTACT -> org.fossify.commons.R.string.view_contact

                else -> org.fossify.commons.R.string.edit_contact

            }

        )

app/src/main/kotlin/org/fossify/contacts/activities/ViewContactActivity.kt

-Original file line number
+Diff line change
@@ Expand Up / @@ -237,7 +237,7 @@ class ViewContactActivity : ContactActivity() { @@
             binding.contactSendEmail.setOnClickListener { trySendEmail() }
             binding.contactSendSms.setOnLongClickListener { toast(org.fossify.commons.R.string.send_sms); true; }
-            binding.contactStartCall.setOnLongClickListener { toast(R.string.call_contact); true; }
+            binding.contactStartCall.setOnLongClickListener { toast(org.fossify.commons.R.string.call_contact); true; }
             binding.contactSendEmail.setOnLongClickListener { toast(org.fossify.commons.R.string.send_email); true; }
             updateTextColors(binding.contactScrollview)
@@ Expand Down @@

app/src/main/res/values-ar/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">لا توجد جهات اتصال بهذا البريد الإلكتروني</string>
         <string name="no_contacts_with_phone_numbers">لا توجد جهات اتصال بهذا الرقم</string>
         <string name="new_contact">جهة اتصال جديدة</string>
-        <string name="edit_contact">تعديل جهة اتصالل</string>
         <string name="select_contact">اختيار جهة اتصال</string>
         <string name="nickname">اللقب</string>
         <string name="no_groups">لا توجد مجموعات</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">إظهار أرقام الهواتف</string>
         <string name="show_contact_thumbnails">عرض صور مصغرة لجهات الإتصال</string>
         <string name="show_dialpad_button">عرض زر لوحة الإتصال على الشاشةالرئيسية</string>
-        <string name="on_contact_click">عند النقر فوق جهة اتصال</string>
-        <string name="call_contact">اتصال بجهة</string>
-        <string name="view_contact">عرض تفاصيل جهة الاتصال</string>
         <string name="manage_shown_contact_fields">إدارة حقول جهات الاتصال المعروضة</string>
         <string name="contacts">جهات الاتصال</string>
         <string name="show_only_contacts_with_numbers">إظهار جهات الاتصال التي لديها أرقام هواتف فقط</string>
@@ Expand Down @@

app/src/main/res/values-az/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ @@
         <string name="send_email_to_group">Grupa e-poçt göndər</string>
         <string name="must_be_at_edit">Kontaktı dəyişmək üçün İdarə et ekranında olmalısınız</string>
         <string name="new_contact">Yeni kontakt</string>
-        <string name="edit_contact">Redaktə et</string>
         <string name="select_contact">Kontakt seç</string>
         <string name="no_groups">Qruplar yoxdur</string>
         <string name="create_new_group">Yeni qrup yarat</string>
@@ Expand All / @@ -28,9 +27,6 @@ @@
         <string name="remove_photo">Şəkli sil</string>
         <string name="show_phone_numbers">Telefon nömrələrini əsas ekranda göstər</string>
         <string name="show_contact_thumbnails">Kontakt görüntülərini göstər</string>
-        <string name="on_contact_click">Kontakta toxunduqda</string>
-        <string name="call_contact">Kontakta zəng et</string>
-        <string name="view_contact">Kontakt detallarına bax</string>
         <string name="manage_shown_contact_fields">Göstərilən kontakt sahəsini idarə et</string>
         <string name="contacts">Kontaktlar</string>
         <string name="no_favorites">Görünür, hələlik heçbir sevimli kontakt əlavə etməmisiniz.</string>
@@ Expand Down @@

app/src/main/res/values-be/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Кантакты з адрасамі электроннай пошты не знойдзены</string>
         <string name="no_contacts_with_phone_numbers">Кантакты з нумарамі тэлефонаў не знойдзены</string>
         <string name="new_contact">Стварыць кантакт</string>
-        <string name="edit_contact">Рэдагаваць кантакт</string>
         <string name="select_contact">Выбраць кантакт</string>
         <string name="nickname">Мянушка</string>
         <string name="no_groups">Няма груп</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Паказваць нумары тэлефонаў</string>
         <string name="show_contact_thumbnails">Паказваць фота кантакту</string>
         <string name="show_dialpad_button">Паказваць панэль набору нумароў на галоўным экране</string>
-        <string name="on_contact_click">Пры націсканні на кантакт</string>
-        <string name="call_contact">Тэлефанаваць кантакту</string>
-        <string name="view_contact">Паказваць звесткі аб кантакце</string>
         <string name="manage_shown_contact_fields">Кіраванне палямі кантактаў, якія адлюстроўваюцца</string>
         <string name="contacts">Кантакты</string>
         <string name="show_only_contacts_with_numbers">Паказваць толькі кантакты з нумарамі тэлефонаў</string>
@@ Expand Down @@

app/src/main/res/values-bg/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Не са открити контакти с адрес на електронна поща</string>
         <string name="no_contacts_with_phone_numbers">Не са открити контакти с телефонен номер</string>
         <string name="new_contact">Нов контакт</string>
-        <string name="edit_contact">Променяне на контакт</string>
         <string name="select_contact">Избиране на контакт</string>
         <string name="nickname">Прякор</string>
         <string name="no_groups">Няма групи</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Показване на телефонните номера</string>
         <string name="show_contact_thumbnails">Показване на миниатюра на контакта</string>
         <string name="show_dialpad_button">Показване на бутон за набиране на главния екран</string>
-        <string name="on_contact_click">При докосване на контакти</string>
-        <string name="call_contact">Обаждане на контакта</string>
-        <string name="view_contact">Преглед на контакта</string>
         <string name="manage_shown_contact_fields">Управление на полетата</string>
         <string name="contacts">Контакти</string>
         <string name="show_only_contacts_with_numbers">Показване само на контактите с телефонен номер</string>
@@ Expand Down @@

app/src/main/res/values-ca/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">No s\'ha trobat cap contacte amb correu electrònic</string>
         <string name="no_contacts_with_phone_numbers">No s\'ha trobat cap contacte amb número de telèfon</string>
         <string name="new_contact">Contacte nou</string>
-        <string name="edit_contact">Edita el contacte</string>
         <string name="select_contact">Selecciona el contacte</string>
         <string name="nickname">Sobrenom</string>
         <string name="no_groups">No hi ha cap grup</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Mostra els números de telèfon</string>
         <string name="show_contact_thumbnails">Mostra les miniatures dels contactes</string>
         <string name="show_dialpad_button">Mostra un botó de teclat de marcatge a la pantalla principal</string>
-        <string name="on_contact_click">En fer clic al contacte</string>
-        <string name="call_contact">Truca al contacte</string>
-        <string name="view_contact">Mostra les dades del contacte</string>
         <string name="manage_shown_contact_fields">Gestiona els camps mostrats de contacte</string>
         <string name="contacts">Contactes</string>
         <string name="show_only_contacts_with_numbers">Mostra només els contactes amb números de telèfon</string>
@@ Expand Down @@

app/src/main/res/values-cs/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Nenalezeny žádné kontakty s e-maily</string>
         <string name="no_contacts_with_phone_numbers">Nenalezeny žádné kontakty s telefonními čísly</string>
         <string name="new_contact">Nový kontakt</string>
-        <string name="edit_contact">Upravit kontakt</string>
         <string name="select_contact">Zvolte kontakt</string>
         <string name="nickname">Přezdívka</string>
         <string name="no_groups">Žádné skupiny</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Zobrazit telefonní čísla</string>
         <string name="show_contact_thumbnails">Zobrazit obrázky kontaktů</string>
         <string name="show_dialpad_button">Zobrazit tlačítko číselníku na hlavní obrazovce</string>
-        <string name="on_contact_click">Po klepnutí na kontakt</string>
-        <string name="call_contact">Zavolat kontakt</string>
-        <string name="view_contact">Zobrazit údaje kontaktu</string>
         <string name="manage_shown_contact_fields">Spravovat zobrazená pole kontaktů</string>
         <string name="contacts">Kontakty</string>
         <string name="show_only_contacts_with_numbers">Zobrazit jen kontakty s telefonními čísly</string>
@@ Expand Down @@

app/src/main/res/values-cy/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,6 @@ @@
         <string name="no_contacts_with_emails">Ni chanfuwyd unrhyw gysylltiadau gydag ebost</string>
         <string name="no_contacts_with_phone_numbers">Ni chanfuwyd unrhyw gysylltiadau gyda rhifau ffôn</string>
         <string name="new_contact">Cyswllt newydd</string>
-        <string name="edit_contact">Golygu\'r cyswllt</string>
         <string name="select_contact">Dewis cyswllt</string>
         <string name="nickname">Llys enw</string>
         <string name="no_groups">Dim grwpiau</string>
@@ Expand All / @@ -32,9 +31,6 @@ @@
         <string name="show_phone_numbers">Dangos rhifau ffôn ar y brif sgrin</string>
         <string name="show_contact_thumbnails">Dangos mân luniau cysylltiadau</string>
         <string name="show_dialpad_button">Dangos botwm pad deialu ar y brif sgrin</string>
-        <string name="on_contact_click">Wrth glicio ar gyswllt</string>
-        <string name="call_contact">Galw cyswllt</string>
-        <string name="view_contact">Gweld manylion cyswllt</string>
         <string name="manage_shown_contact_fields">Rheoli pa feysydd cyswllt i\'w dangos</string>
         <string name="contacts">Cysylltiadau</string>
         <string name="show_only_contacts_with_numbers">Dangos dim ond cysylltiadau gyda rhifau ffôn</string>
@@ Expand Down @@

app/src/main/res/values-da/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Ingen kontakter med e-mails fundet</string>
         <string name="no_contacts_with_phone_numbers">Ingen kontakter med telefonnumre fundet</string>
         <string name="new_contact">Ny kontakt</string>
-        <string name="edit_contact">Rediger kontakt</string>
         <string name="select_contact">Vælg kontakt</string>
         <string name="nickname">Kaldenavn</string>
         <string name="no_groups">Ingen grupper</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Vis telefonnumre</string>
         <string name="show_contact_thumbnails">Vis miniaturebilleder af kontakter</string>
         <string name="show_dialpad_button">Vis en tastaturknap på hovedskærmen</string>
-        <string name="on_contact_click">Ved klik på kontakt</string>
-        <string name="call_contact">Ring til kontakt</string>
-        <string name="view_contact">Vis kontaktdetaljer</string>
         <string name="manage_shown_contact_fields">Administrer viste kontaktfelter</string>
         <string name="contacts">Kontakter</string>
         <string name="show_only_contacts_with_numbers">Vis kun kontakter med telefonnumre</string>
@@ Expand Down @@

app/src/main/res/values-de/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Keine Kontakte mit E-Mail-Adressen gefunden</string>
         <string name="no_contacts_with_phone_numbers">Keine Kontakte mit Telefonnummern gefunden</string>
         <string name="new_contact">Neuer Kontakt</string>
-        <string name="edit_contact">Kontakt bearbeiten</string>
         <string name="select_contact">Kontakt auswählen</string>
         <string name="nickname">Spitzname</string>
         <string name="no_groups">Keine Gruppen</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Telefonnummern anzeigen</string>
         <string name="show_contact_thumbnails">Vorschaubilder der Kontakte zeigen</string>
         <string name="show_dialpad_button">Eine Wähltastenfeld-Schaltfläche auf dem Hauptbildschirm anzeigen</string>
-        <string name="on_contact_click">Beim Klicken auf den Kontakt</string>
-        <string name="call_contact">Kontakt anrufen</string>
-        <string name="view_contact">Kontaktdetails anzeigen</string>
         <string name="manage_shown_contact_fields">Sichtbare Kontaktfelder bearbeiten</string>
         <string name="contacts">Kontakte</string>
         <string name="show_only_contacts_with_numbers">Nur Kontakte mit Telefonnummern anzeigen</string>
@@ Expand Down @@

app/src/main/res/values-el/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Δεν βρέθηκαν Επαφές με emails</string>
         <string name="no_contacts_with_phone_numbers">Δεν βρέθηκαν Επαφές με αριθμό τηλεφώνου</string>
         <string name="new_contact">Νέα επαφή</string>
-        <string name="edit_contact">Επεξεργασία επαφής</string>
         <string name="select_contact">Επιλογή επαφής</string>
         <string name="nickname">Ψευδώνυμο</string>
         <string name="no_groups">Δεν υπάρχουν ομάδες</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Εμφάνιση αριθμών τηλεφώνων</string>
         <string name="show_contact_thumbnails">Εμφάνιση μικρογραφιών επαφής</string>
         <string name="show_dialpad_button">Προβολή ενός κουμπίου πληκτρολογίου στην κύρια οθόνη</string>
-        <string name="on_contact_click">Στην επιλογή επαφής</string>
-        <string name="call_contact">Κλήση επαφής</string>
-        <string name="view_contact">Εμφάνιση λεπτομερειών επαφής</string>
         <string name="manage_shown_contact_fields">Διαχείριση πεδίων επαφής</string>
         <string name="contacts">Επαφές</string>
         <string name="show_only_contacts_with_numbers">Προβολή όλων των Επαφών με αριθμούς τηλεφώνου</string>
@@ Expand Down @@

app/src/main/res/values-eo/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -6,7 +6,6 @@ @@
         <string name="updating">Ĝisdatigante…</string>
         <string name="company">Firmao</string>
         <string name="new_contact">Nova kontakto</string>
-        <string name="edit_contact">Modifi kontakton</string>
         <string name="select_contact">Elekti kontakton</string>
         <string name="nickname">Alnomo</string>
         <string name="no_groups">Neniu grupo</string>
@@ Expand Down Expand Up / @@ -36,11 +35,8 @@ @@
         <string name="no_group_created">Estas neniu kontakta grupo sur la aparato</string>
         <string name="change_photo">Ŝanĝi foton</string>
         <string name="show_contact_thumbnails">Montri bildetojn de kontaktoj</string>
-        <string name="view_contact">Vidi kontaktajn detalojn</string>
         <string name="contacts">Kontaktoj</string>
         <string name="no_favorites">Ŝajnas, ke vi ankoraŭ ne aldonis iun ajn plej ŝatatan kontakton.</string>
-        <string name="on_contact_click">Kiam kontakto estas frapetita</string>
-        <string name="call_contact">Alvoki kontakton</string>
         <string name="manage_shown_contact_fields">Administri videblajn kampojn de kontakto</string>
         <string name="show_only_contacts_with_numbers">Nur montri kontaktojn kun telefonnumeroj</string>
         <string name="merge_duplicate_contacts">Kunfandi duobligitajn kontaktojn</string>
@@ Expand Down @@

app/src/main/res/values-es/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">No se encontraron contactos con correo electrónico</string>
         <string name="no_contacts_with_phone_numbers">No se encontraron contactos con número de teléfono</string>
         <string name="new_contact">Contacto nuevo</string>
-        <string name="edit_contact">Editar contacto</string>
         <string name="select_contact">Seleccionar contacto</string>
         <string name="nickname">Apodo</string>
         <string name="no_groups">No hay grupos</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Mostrar números telefónicos</string>
         <string name="show_contact_thumbnails">Mostrar minaturas de contactos</string>
         <string name="show_dialpad_button">Mostrar botón de marcación en la pantalla principal</string>
-        <string name="on_contact_click">Al tocar contacto</string>
-        <string name="call_contact">Llamar contacto</string>
-        <string name="view_contact">Ver detalles del contacto</string>
         <string name="manage_shown_contact_fields">Gestionar campos del contacto mostrados</string>
         <string name="contacts">Contactos</string>
         <string name="show_only_contacts_with_numbers">Solo mostrar contactos con números telefónicos</string>
@@ Expand Down @@

app/src/main/res/values-et/strings.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -17,7 +17,6 @@ @@
         <string name="no_contacts_with_emails">Ei leidunud ühtegi kontakti, kus oleks kirjas e-posti aadress</string>
         <string name="no_contacts_with_phone_numbers">Ei leidunud ühtegi kontakti, kus oleks olemas telefoninumber</string>
         <string name="new_contact">Uus kontakt</string>
-        <string name="edit_contact">Muuda kontakti</string>
         <string name="select_contact">Vali kontakt</string>
         <string name="nickname">Hüüdnimi</string>
         <string name="no_groups">Rühmad puuduvad</string>
@@ Expand All / @@ -34,9 +33,6 @@ @@
         <string name="show_phone_numbers">Näita telefoninumbreid</string>
         <string name="show_contact_thumbnails">Näita kontaktide pisipilte</string>
         <string name="show_dialpad_button">Näita põhivaates telefoniklahvistikku</string>
-        <string name="on_contact_click">Kontaktil klõpsamisel</string>
-        <string name="call_contact">Helista</string>
-        <string name="view_contact">Vaata kontaktandmeid</string>
         <string name="manage_shown_contact_fields">Halda kuvatavaid kontaktkirje välju</string>
         <string name="contacts">Kontaktid</string>
         <string name="show_only_contacts_with_numbers">Näita vaid kontakte, kellel on telefoninumber</string>
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(l10n): remove duplicate contact click strings #479

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!