Finished Robot Code #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/com/frcteam3636/bunnybots2025/Robot.kt
Member
Author
|
It's a lot of code, I know. Skip over the Choreo library source code for obvious reasons. Only review actual robot code please :) |
Gavin-Niederman
requested changes
Nov 19, 2025
Member
Gavin-Niederman
left a comment
Gavin-Niederman
left a comment
There was a problem hiding this comment.
will do second pass in the future, overall except for the one issue and nit LGTM
| Indexer.index(), | ||
| blinkLimelight() | ||
| ).alongWith( | ||
| Commands.sequence( |
Member
There was a problem hiding this comment.
make sure that the right commands are repeated
| beforeFirstEnable = true | ||
| // autoCommand = Dashboard.autoChooser.selected | ||
| autoCommand?.schedule() | ||
| if (!RobotState.beforeFirstEnable) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists so main always has working code that corresponds to the currently built robot. As of right now that's just a Mk5n drivetrain.