Submit Button Not Displayed After All Expenses Are Rejected Until Page Refresh

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.3-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @CosminStreteaCS
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

Precondition:
User A is an admin of a workspace
User B is a workspace member

As User B

1. Open the workspace chat
2. Create a new report
3. Add two expenses
4. Submit the report
   As User A
5. Open the newly submitted report
6. Select all expenses
7. Reject the selected expenses
   As User B
8. View the rejected report without refreshing the page

Expected Result:

The report updates immediately after rejection
A Reject by Reason (RBR) is shown
The Submit button reappears automatically

Actual Result:

The Submit button is not displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug.1.iOS.MP4

Bug.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When all expenses in a submitted report are rejected by an admin, the report owner (User B) doesn't see the Submit button until they refresh the page. The report should immediately update to show the Submit button after all expenses are rejected.

What is the root cause of that problem?

The issue is in how rejectMoneyRequestsOnSearch handles rejecting all expenses when delayed submission is disabled.

Looking at the conditional logic in /src/libs/actions/Search.ts lines 878-886:

if (isPolicyDelayedSubmissionEnabled && areAllExpensesSelected) {
    rejectMoneyRequestInBulk(reportID, comment, policy, selectedTransactionIDs, hash);
} else {
    // Share a single destination ID across all rejections from the same source report
    const sharedRejectedToReportID = generateReportID();
    for (const transactionID of selectedTransactionIDs) {
        rejectMoneyRequest(transactionID, reportID, comment, policy, {sharedRejectedToReportID});
    }
}

When delayed submission is disabled, even if ALL expenses are selected, the code uses individual rejectMoneyRequest calls instead of rejectMoneyRequestInBulk.

The individual rejectMoneyRequest flow in prepareRejectMoneyRequestData (/src/libs/actions/IOU/index.ts around line 12275) sets reportID: null on each transaction:

{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
    value: {
        reportID: null,  // This causes the issue
        ...(transactionCommentCleanup ?? {}),
    },
},

When reportID: null is set optimistically on transactions, getReportTransactions(reportID) returns an empty array because transactions with falsy reportID are filtered out in ReportUtils.ts.

Then in isSubmitAction (ReportPrimaryActionUtils.ts), the check reportTransactions.length !== 0 fails, so the Submit button doesn't appear.

After a page refresh, the server data is fetched and transactions have their proper reportID values, so the Submit button shows correctly.

What changes do you think we should make in order to solve the problem?

Change the condition in rejectMoneyRequestsOnSearch to use the bulk action path whenever ALL expenses are selected, regardless of the delayed submission setting:

File: /src/libs/actions/Search.ts

-        if (isPolicyDelayedSubmissionEnabled && areAllExpensesSelected) {
+        if (areAllExpensesSelected) {
             rejectMoneyRequestInBulk(reportID, comment, policy, selectedTransactionIDs, hash);
         } else {

The bulk rejection path (rejectMoneyRequestInBulk) correctly:

1. Keeps transactions associated with the report (doesn't set reportID: null)
2. Sets the report status to OPEN

This ensures that when all expenses are rejected:

1. getReportTransactions() returns the rejected transactions
2. isSubmitAction() passes all checks and shows the Submit button

The current behavior for partial rejections (not all expenses selected) remains unchanged.

What alternative solutions did you explore?

Could modify prepareRejectMoneyRequestData to not set reportID: null when there are multiple expenses. However, this approach would also require adding logic to set the report status to OPEN, adding complexity to an already complex function.

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.

• After an admin rejects all expenses in a submitted workspace report, the member sees the rejection.
• But the report stays in SUBMITTED on the client.
• The Submit button does not come back until a full refresh.

What is the root cause of that problem?

• During optimistic rejection, the report is never reopened in Onyx.
• The stateNum and statusNum are not set back to OPEN.
• So the client still thinks the report is SUBMITTED.

What changes do you think we should make in order to solve the problem?

• Add a single rule in prepareRejectMoneyRequestData.
• If a submitted, non-IOU report is rejected, reopen it right away.
• Apply this for optimistic, success, and failure updates.
• This works for both bulk and sequential rejects.

Code change (add near the start of prepareRejectMoneyRequestData, after computing report, policy, isIOU, etc., before existing branch logic):

const shouldReopenReport = !isIOU && report?.statusNum === CONST.REPORT.STATUS_NUM.SUBMITTED;
if (shouldReopenReport) {
    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: {
            stateNum: CONST.REPORT.STATE_NUM.OPEN,
            statusNum: CONST.REPORT.STATUS_NUM.OPEN,
            pendingFields: {
                ...(report.pendingFields ?? {}),
                stateNum: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                statusNum: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
            },
        },
    });

    successData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: {
            pendingFields: {
                ...(report.pendingFields ?? {}),
                stateNum: null,
                statusNum: null,
            },
            errorFields: {
                ...(report.errorFields ?? {}),
                stateNum: null,
                statusNum: null,
            },
        },
    });

    failureData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
        value: {
            stateNum: report?.stateNum,
            statusNum: report?.statusNum,
            pendingFields: {
                ...(report.pendingFields ?? {}),
                stateNum: null,
                statusNum: null,
            },
        },
    });
}

What alternative solutions did you explore? (Optional)
Make all rejections use only bulk logic.
This does not cover sequential paths.
It also does not guarantee the report reopens.

[melvin-bot]

@heyjennahay Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!