Skip to content

Fix Spark TTFB calculation to exclude Graphsync retrievals #476

@pyropy

Description

@pyropy

Descrption

Current Spark TTFB score include both values from HTTP and Graphsync retrievals. This is not exactly correct behaviour as TTFB reported for Graphsync is the time when the whole retrieval has been performed by lassie and on the other hand time reported for HTTP is the time when the first byte has been received.

We want to exclude Graphsync retrievals from Spark TTFB score by using only retrievals done over HTTP.

Context from Slack conversations we previously had:

@juliangruber and I have been reviewing the Spark TTFB documentation I’ve been drafting during our 1:1s. We realized it would be best to exclude Graphsync measurements from the TTFB calculation, as they do not accurately reflect the actual TTFB of SPs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    Status

    📥 candidate

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions