Merge pull request #731 from AnswerDotAI/slice

add slice support for L assignment

Author: jph00

fastcore/foundation.py

@@ -139,7 +139,7 @@ def _get(self, i):
 
     def __setitem__(self, idx, o):
         "Set `idx` (can be list of indices, or mask, or int) items to `o` (which is broadcast if not iterable)"
-        if isinstance(idx, int): self.items[idx] = o
+        if isinstance(idx, int) or isinstance(idx, slice): self.items[idx] = o
         else:
             idx = idx if isinstance(idx,L) else listify(idx)
             if not is_iter(o): o = [o]*len(idx)

nbs/02_foundation.ipynb

@@ -783,11 +783,11 @@
      "data": {
       "text/plain": [
        "[Path('files/test.txt.bz2'),\n",
-       " Path('images/mnist3.png'),\n",
        " Path('images/att_00000.png'),\n",
        " Path('images/att_00005.png'),\n",
-       " Path('images/att_00007.png'),\n",
        " Path('images/att_00006.png'),\n",
+       " Path('images/att_00007.png'),\n",
+       " Path('images/mnist3.png'),\n",
        " Path('images/puppy.jpg')]"
       ]
      },
@@ -937,7 +937,7 @@
     "\n",
     "    def __setitem__(self, idx, o):\n",
     "        \"Set `idx` (can be list of indices, or mask, or int) items to `o` (which is broadcast if not iterable)\"\n",
-    "        if isinstance(idx, int): self.items[idx] = o\n",
+    "        if isinstance(idx, int) or isinstance(idx, slice): self.items[idx] = o\n",
     "        else:\n",
     "            idx = idx if isinstance(idx,L) else listify(idx)\n",
     "            if not is_iter(o): o = [o]*len(idx)\n",
@@ -1036,7 +1036,7 @@
     {
      "data": {
       "text/plain": [
-       "[0, 1, 2, 'j', 4, 'k', 6, 7, 8, 9, 10, 11]"
+       "[1, 2, 3, 'j', 4, 'k', 6, 7, 8, 9, 10, 11]"
       ]
      },
      "execution_count": null,
@@ -1054,6 +1054,8 @@
     "test_eq(t[3,5], [\"j\",\"k\"])\n",
     "test_eq(t, L(t))\n",
     "test_eq(L(L(1,2),[3,4]), ([1,2],[3,4]))\n",
+    "t[0:3] = [1, 2, 3]\n",
+    "test_eq(t[0:3], [1, 2, 3])\n",
     "t"
    ]
   },
@@ -1094,7 +1096,7 @@
     {
      "data": {
       "text/plain": [
-       "[6, 11, 0]"
+       "[6, 11, 1]"
       ]
      },
      "execution_count": null,
@@ -4150,7 +4152,7 @@
       "text/markdown": [
        "---\n",
        "\n",
-       "[source](https://github.com/AnswerDotAI/fastcore/blob/main/fastcore/foundation.py#L636){target=\"_blank\" style=\"float:right; font-size:smaller\"}\n",
+       "[source](https://github.com/AnswerDotAI/fastcore/blob/main/fastcore/foundation.py#L650){target=\"_blank\" style=\"float:right; font-size:smaller\"}\n",
        "\n",
        "### Config.get\n",
        "\n",
@@ -4245,7 +4247,7 @@
       "text/markdown": [
        "---\n",
        "\n",
-       "[source](https://github.com/AnswerDotAI/fastcore/blob/main/fastcore/foundation.py#L650){target=\"_blank\" style=\"float:right; font-size:smaller\"}\n",
+       "[source](https://github.com/AnswerDotAI/fastcore/blob/main/fastcore/foundation.py#L664){target=\"_blank\" style=\"float:right; font-size:smaller\"}\n",
        "\n",
        "### Config.find\n",
        "\n",