Skip to content

Commit f48962b

Browse files
authored
Refactor layout error assertion to use path normalization (#3203)
To prevent false negatives in tests due to path formatting differences: * Updated expected error message to use `path.normalize(config.dbFile)` instead of `config.dbFile.split('./')[1]`, see docs: https://nodejs.org/api/path.html#pathnormalizepath * Ensures consistent behavior across platforms * Improves resilience when users provide paths with mixed or repeated slashes
1 parent edc3a89 commit f48962b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

QualityControl/test/lib/services/JsonFileService.test.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import assert from 'assert';
1717
import fs from 'fs';
1818
import { JsonFileService } from '../../../lib/services/JsonFileService.js';
1919
import { config } from '../../config.js';
20+
import { normalize } from 'node:path';
2021

2122
export const jsonFileServiceTestSuite = async () => {
2223
suite('JSON File Service Test Suite', () => {
@@ -42,7 +43,7 @@ export const jsonFileServiceTestSuite = async () => {
4243
return assert.rejects(
4344
service.ready,
4445
(err) => err instanceof Error
45-
&& err.message === `DB file should have an array of layouts ${config.dbFile.split('./')[1]}`,
46+
&& err.message === `DB file should have an array of layouts ${normalize(config.dbFile)}`,
4647
);
4748
});
4849

@@ -52,7 +53,7 @@ export const jsonFileServiceTestSuite = async () => {
5253
return assert.rejects(
5354
service.ready,
5455
(err) => err instanceof Error
55-
&& err.message === `Unable to parse DB file ${config.dbFile.split('./')[1]}`,
56+
&& err.message === `Unable to parse DB file ${normalize(config.dbFile)}`,
5657
);
5758
});
5859

@@ -62,7 +63,7 @@ export const jsonFileServiceTestSuite = async () => {
6263
return assert.rejects(
6364
service.ready,
6465
(err) => err instanceof Error
65-
&& err.message === `DB file should have an array of layouts ${config.dbFile.split('./')[1]}`,
66+
&& err.message === `DB file should have an array of layouts ${normalize(config.dbFile)}`,
6667
);
6768
});
6869

@@ -87,7 +88,7 @@ export const jsonFileServiceTestSuite = async () => {
8788
await assert.rejects(
8889
service.ready,
8990
(err) => err instanceof Error
90-
&& err.message === `Unable to parse DB file ${config.dbFile.split('./')[1]}`,
91+
&& err.message === `Unable to parse DB file ${normalize(config.dbFile)}`,
9192
);
9293
});
9394
});

0 commit comments

Comments
 (0)